Bug 87086 – PAGE_POPUP: window.setValueAndClosePopup should be moved to a per-context property of DOMWindow.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kent Tamura]

[V8] PAGE_POPUP: window.setValueAndClosePopup should be a per-context function

[Kent Tamura]

Created attachment 143245 [details]
WIP

[Kent Tamura]

Created attachment 143246 [details]
WIP 2

[Hajime Morrita]

Comment on attachment 143246 [details]
WIP 2

View in context: https://bugs.webkit.org/attachment.cgi?id=143246&action=review

Maybe we could define window.popupController attribute instead of function.
Then popup window can turn to be a supplemental module.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:368
> +        if ($attrExt->{"V8EnablePerContext"}) {

EnableAtRuntime and EnablePerContext should be mutually exclusive. So else if would be preferred.

[Kent Tamura]

> Maybe we could define window.popupController attribute instead of function.
> Then popup window can turn to be a supplemental module.

It make sense.  It's extensible and I don't need to touch a Perl code though we need to add one more C++ class and IDL.

[Kent Tamura]

Created attachment 143479 [details]
Patch

[Adam Barth]

Comment on attachment 143479 [details]
Patch

Should we add a test that pagePopupController doesn't appear on the default Window object by mistake?

[Hajime Morrita]

(In reply to comment #6)
> (From update of attachment 143479 [details])
> Should we add a test that pagePopupController doesn't appear on the default Window object by mistake?
That sounds nice. Just having a test which checks pagePopController 
will be sufficient.
If we have a way to enable it from testing API, it would be greater.
But that is another story.

[Kent Tamura]

Created attachment 143980 [details]
Patch for landing

Add a simple test

[WebKit Review Bot]

Comment on attachment 143980 [details]
Patch for landing

Clearing flags on attachment: 143980

Committed r118482: <http://trac.webkit.org/changeset/118482>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.