Bug 87083 - [V8] setDOMException() should return v8::Handle<v8::Value>()
Summary: [V8] setDOMException() should return v8::Handle<v8::Value>()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency treegraph
 
Reported: 2012-05-21 23:04 PDT by Kentaro Hara
Modified: 2012-05-22 00:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (15.77 KB, patch)
2012-05-21 23:08 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-21 23:04:45 PDT
The following patterns are used here and there in V8 bindings:

    setDOMException();
    return v8::Handle<v8::Value>();

and

    setDOMException();
    return v8::Undefined();

By returning v8::Handle<v8::Value>() from setDOMException(), we can simplify the above patterns into this:

    return setDOMException();
Comment 1 Kentaro Hara 2012-05-21 23:08:53 PDT
Created attachment 143195 [details]
Patch
Comment 2 Adam Barth 2012-05-21 23:52:27 PDT
Comment on attachment 143195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143195&action=review

> Source/WebCore/bindings/v8/V8Proxy.cpp:592
> -        return;
> +        return v8::Handle<v8::Value>();

Should we return v8::Local<v8::Value> ?  I guess it doesn't matter for empty handles.
Comment 3 Kentaro Hara 2012-05-21 23:55:21 PDT
Comment on attachment 143195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143195&action=review

>> Source/WebCore/bindings/v8/V8Proxy.cpp:592
>> +        return v8::Handle<v8::Value>();
> 
> Should we return v8::Local<v8::Value> ?  I guess it doesn't matter for empty handles.

It doesn't matter. V8::Local<v8::Value> can be casted to v8::Handle<v8::Value>. I used v8::Handle<v8::Value> just because throwError()s return v8::Handle<v8::Value>. Do you think V8::Local<v8::Value> is better?
Comment 4 Adam Barth 2012-05-21 23:56:09 PDT
I don't think it makes any difference for empty handles.
Comment 5 WebKit Review Bot 2012-05-22 00:41:28 PDT
Comment on attachment 143195 [details]
Patch

Clearing flags on attachment: 143195

Committed r117926: <http://trac.webkit.org/changeset/117926>
Comment 6 WebKit Review Bot 2012-05-22 00:41:39 PDT
All reviewed patches have been landed.  Closing bug.