Bug 87083 – [V8] setDOMException() should return v8::Handle<v8::Value>()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

The following patterns are used here and there in V8 bindings:

    setDOMException();
    return v8::Handle<v8::Value>();

and

    setDOMException();
    return v8::Undefined();

By returning v8::Handle<v8::Value>() from setDOMException(), we can simplify the above patterns into this:

    return setDOMException();

[Kentaro Hara]

Created attachment 143195 [details]
Patch

[Adam Barth]

Comment on attachment 143195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143195&action=review

> Source/WebCore/bindings/v8/V8Proxy.cpp:592
> -        return;
> +        return v8::Handle<v8::Value>();

Should we return v8::Local<v8::Value> ?  I guess it doesn't matter for empty handles.

[Kentaro Hara]

Comment on attachment 143195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143195&action=review

>> Source/WebCore/bindings/v8/V8Proxy.cpp:592
>> +        return v8::Handle<v8::Value>();
> 
> Should we return v8::Local<v8::Value> ?  I guess it doesn't matter for empty handles.

It doesn't matter. V8::Local<v8::Value> can be casted to v8::Handle<v8::Value>. I used v8::Handle<v8::Value> just because throwError()s return v8::Handle<v8::Value>. Do you think V8::Local<v8::Value> is better?

[Adam Barth]

I don't think it makes any difference for empty handles.

[WebKit Review Bot]

Comment on attachment 143195 [details]
Patch

Clearing flags on attachment: 143195

Committed r117926: <http://trac.webkit.org/changeset/117926>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.