Bug 87079 - [V8] Replace 'throwError(); return Undefined();' with 'return throwError()'
Summary: [V8] Replace 'throwError(); return Undefined();' with 'return throwError()'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency tree / graph
 
Reported: 2012-05-21 22:33 PDT by Kentaro Hara
Modified: 2012-05-22 00:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.35 KB, patch)
2012-05-21 22:36 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-21 22:33:07 PDT 
We can replace

    throwError();
    return v8::Undefined();

with

    return throwError();
Comment 1 Kentaro Hara 2012-05-21 22:36:09 PDT 
Created attachment 143189 [details]
Patch
Comment 2 Adam Barth 2012-05-21 23:50:04 PDT 
Comment on attachment 143189 [details]
Patch

So much prettier.
Comment 3 WebKit Review Bot 2012-05-22 00:24:40 PDT 
Comment on attachment 143189 [details]
Patch

Clearing flags on attachment: 143189

Committed r117923: <http://trac.webkit.org/changeset/117923>
Comment 4 WebKit Review Bot 2012-05-22 00:24:53 PDT 
All reviewed patches have been landed.  Closing bug.