Bug 87072 - Assertion failure when mouse points to a direct child text node of shadow root
Summary: Assertion failure when mouse points to a direct child text node of shadow root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 86999
  Show dependency treegraph
 
Reported: 2012-05-21 19:30 PDT by Hayato Ito
Modified: 2012-05-22 22:39 PDT (History)
8 users (show)

See Also:


Attachments
remove an assertion (6.69 KB, patch)
2012-05-21 21:00 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff
Patch for landing (6.69 KB, patch)
2012-05-22 21:50 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-05-21 19:30:28 PDT
Let me quote the test case from https://bugs.webkit.org/show_bug.cgi?id=86795#c3.

<div id="container"></div>
<script>
var shadowRoot = new WebKitShadowRoot(document.getElementById('container'));
shadowRoot.innerHTML = 'a';
</script>


Moving the cursor over the 'a' results in the following assert:
ASSERTION FAILED: !m_node->isShadowRoot()
../../third_party/WebKit/Source/WebCore/dom/ComposedShadowTreeWalker.h(81) : void WebCore::ComposedShadowTreeWalker::assertPrecondition() const
Comment 1 Hayato Ito 2012-05-21 21:00:32 PDT
Created attachment 143186 [details]
remove an assertion
Comment 2 Dimitri Glazkov (Google) 2012-05-22 09:24:32 PDT
Comment on attachment 143186 [details]
remove an assertion

View in context: https://bugs.webkit.org/attachment.cgi?id=143186&action=review

> Source/WebCore/dom/ComposedShadowTreeWalker.cpp:57
> +    // assertPrecondition();

We usually don't land commented code like this. Perhaps your FIXME description could mention it.
Comment 3 Hayato Ito 2012-05-22 18:57:43 PDT
Thank you for the review.

(In reply to comment #2)
> (From update of attachment 143186 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143186&action=review
> 
> > Source/WebCore/dom/ComposedShadowTreeWalker.cpp:57
> > +    // assertPrecondition();
> 
> We usually don't land commented code like this. Perhaps your FIXME description could mention it.

Okay. I'll mention that in FIXME. Let me land this after that, merging with ToT.
Comment 4 Hayato Ito 2012-05-22 21:50:09 PDT
Created attachment 143458 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-05-22 22:39:37 PDT
Comment on attachment 143458 [details]
Patch for landing

Clearing flags on attachment: 143458

Committed r118125: <http://trac.webkit.org/changeset/118125>
Comment 6 WebKit Review Bot 2012-05-22 22:39:44 PDT
All reviewed patches have been landed.  Closing bug.