As per the new spec. It actually hardcodes tagnames that should be coerced to display:block when they are in a flexbox. It also says "An atomic inline-level child of a flex container" should be a flex-item. I'm not really sure what that refers to since it's a different item than the replaced items and the spec refers to button as an atomic inline-level child. Tab, can you clarify?
"atomic inline" refers to things that are inline-level, but lay out as a single thing: inline-block, inline-table, inline replaced, etc. All the hardcoded tag names should have already been flexbox items, since they all fall under the "replaced element" umbrella - the new entry with hardcoded names is just meant to cover the odd case where an element can be replaced or not depending on whether a link resolves.
Created attachment 147141 [details] Patch
Created attachment 147142 [details] Patch
Comment on attachment 147142 [details] Patch Added a link to the spec in the ChangeLog.
Comment on attachment 147142 [details] Patch Attachment 147142 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12944649
Created attachment 147143 [details] Patch
Comment on attachment 147143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147143&action=review > Source/WebCore/css/StyleResolver.cpp:1923 > +static bool shouldBecomeBlockWhenParentIsFlexbox(const Element* element) This should probably include a link to the spec. > LayoutTests/css3/flexbox/resources/flexbox.js:69 > + var expectedDisplay = node.getAttribute && node.getAttribute("data-display"); Nit: should the attribute name be data-expected-display?
Created attachment 147152 [details] Patch for landing
Comment on attachment 147143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147143&action=review >> Source/WebCore/css/StyleResolver.cpp:1923 >> +static bool shouldBecomeBlockWhenParentIsFlexbox(const Element* element) > > This should probably include a link to the spec. I didn't want to include a link to the working draft in code. Once it's finalized or CR stage, it would probably be OK. >> LayoutTests/css3/flexbox/resources/flexbox.js:69 >> + var expectedDisplay = node.getAttribute && node.getAttribute("data-display"); > > Nit: should the attribute name be data-expected-display? Renamed.
Comment on attachment 147152 [details] Patch for landing Clearing flags on attachment: 147152 Committed r120132: <http://trac.webkit.org/changeset/120132>
All reviewed patches have been landed. Closing bug.