RESOLVED FIXED 87066
[chromium] Add unit testing for WebTransformationMatrix::blend() 
https://bugs.webkit.org/show_bug.cgi?id=87066
Summary [chromium] Add unit testing for WebTransformationMatrix::blend()
Shawn Singh
Reported 2012-05-21 18:25:46 PDT
https://bugs.webkit.org/show_bug.cgi?id=86421 did not finish adding unit tests for WebTransformationMatrix::blend(). This patch fills the missing tests.
Attachments
Patch (13.96 KB, patch)
2012-05-21 18:33 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
Also fix a badly hardcoded include file (14.02 KB, patch)
2012-05-22 09:48 PDT, Shawn Singh 		enne: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2012-05-21 18:33:13 PDT
Created attachment 143162 [details] Patch
James Robinson
Comment 2 2012-05-21 18:42:21 PDT
Comment on attachment 143162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143162&action=review > Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp:27 > #include "../../../../Platform/chromium/public/WebTransformationMatrix.h" what on earth happened here? this should be <public/WebTransformationMatrix.h>
Shawn Singh
Comment 3 2012-05-22 09:48:10 PDT
Created attachment 143316 [details] Also fix a badly hardcoded include file This will cause style bots to complain, but I think its actually the style we want
WebKit Review Bot
Comment 4 2012-05-22 09:50:27 PDT
Attachment 143316 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adrienne Walker
Comment 5 2012-05-22 14:09:24 PDT
Comment on attachment 143316 [details] Also fix a badly hardcoded include file R=me. The skewY case is sad, but handling it like that seems pretty reasonable.
Shawn Singh
Comment 6 2012-05-22 14:16:01 PDT
Thanks, as always =)
Shawn Singh
Comment 7 2012-05-22 14:22:20 PDT
Committed r118054: <http://trac.webkit.org/changeset/118054>
Note You need to log in before you can comment on or make changes to this bug.