Bug 87062 – [TextureMapper] [Cairo] Implement repaint counters

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Martin Robinson]

Repaint counters can be useful for debugging content that is composited with AC and AC implementations.

[Martin Robinson]

Created attachment 143160 [details]
Patch

[Martin Robinson]

This code in Cairo only, but if the Qt port is interested in this feature, I'm willing to write it using QPainter. The reason I did not use generic GraphicsContext APIs it that it would require some interaction with the FontCache and using the toy platform interface seems simpler all around.

[Noam Rosenthal]

Comment on attachment 143160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143160&action=review

I'm ok with the texture-mapper changes, though I'm not qualified to review the cairo-specific code :)
We'd love a QPainter implementation of this, though we'd have to do this in the LayerBackingStore code which is the proper place in WebKit2.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:573
> +#if USE(CAIRO)

This would be more readable inside the function.

[Gustavo Noronha (kov)]

Comment on attachment 143160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143160&action=review

I'm just not sure about the border color, feels like you may want to have a border distinct from the background, but I guess it'll look readable like this anyway.

>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:573
>> +#if USE(CAIRO)
> 
> This would be more readable inside the function.

Hmm, I think it would be less readable with different implementations taking the whole function body. As it is now it's pretty obvious that each implementation has a completely different implementation.

[WebKit Review Bot]

Comment on attachment 143160 [details]
Patch

Rejecting attachment 143160 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 138079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 138079.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12763103

[Martin Robinson]

Committed r118061: <http://trac.webkit.org/changeset/118061>