Implement DOM4 DOMError
Created attachment 143120 [details] Patch
This is a bit of a strawman - I need this class for some IndexedDB work, but this isn't implemented anywhere. There also isn't any DOM-spec'ed way to create one of these. (aside from exposure in the IndexedDB API)
Here's the spec, FWIW: http://www.w3.org/TR/dom/#interface-domerror
Comment on attachment 143120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143120&action=review > Source/WebCore/dom/DOMError.idl:33 > + readonly attribute DOMString name; This line should be intended four more spaces.
Comment on attachment 143120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143120&action=review > Source/WebCore/ChangeLog:11 > + No new tests. I wasn't sure how to test this because it isn't > + used yet. I'm open to suggestions. This patch isn't testable because you're not using this object anywhere yet and you haven't exposed the constructor on DOMWindow. (I'm not sure if you intended to expose the constructor on DOMWindow or not.) > Source/WebCore/dom/DOMError.idl:31 > + JSGenerateToNativeObject Is this attribute needed? https://trac.webkit.org/wiki/WebKitIDL#JSGenerateToJSObject
Comment on attachment 143120 [details] Patch This patch looks fine. The spec doesn't say to expose this via DOMWindow, so I don't think there's anyway to test this patch. When you use the object in IDB, we should add some tests to exercise the code.
Comment on attachment 143120 [details] Patch Note: You'll need to add the new files to a bunch more build systems. You can grep WebCore for DOMStringList.cpp and DOMStringList.idl to get a sense for where all you'll need to list these files.
Created attachment 143129 [details] Patch
great thanks - I misunderstood that IDL flag. I took a pass through the other build systems. I'll see if this is enough through the bots.
Comment on attachment 143129 [details] Patch Looks like you're missing vcproj and xcodebuild files.
Created attachment 143352 [details] Patch
sorry abarth@ I keep forgetting to land-safely rather than upload.. one more review here (got vcproj and xcode taken care of)
Comment on attachment 143352 [details] Patch Looks like your patch didn't apply. You might need to update it to top-of-tree.
Created attachment 143600 [details] Patch for landing
Comment on attachment 143600 [details] Patch for landing Rejecting attachment 143600 [details] from commit-queue. alecflett@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
jsbell@ - cq? I tried to land-safely but of course I couldn't cuz I'm not yet a committer
Comment on attachment 143600 [details] Patch for landing Clearing flags on attachment: 143600 Committed r118226: <http://trac.webkit.org/changeset/118226>
All reviewed patches have been landed. Closing bug.