Bug 87053 - [GTK] [WebKit2] Add an API to enable and disable composited layer indicators
: [GTK] [WebKit2] Add an API to enable and disable composited layer indicators
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 86037
:
  Show dependency treegraph
 
Reported: 2012-05-21 15:34 PST by
Modified: 2012-05-23 09:06 PST (History)


Attachments
Patch (7.42 KB, patch)
2012-05-21 16:33 PST, Martin Robinson
no flags Review Patch | Details | Formatted Diff | Diff
Patch with unit test and doc fix (8.37 KB, patch)
2012-05-22 11:15 PST, Martin Robinson
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-21 15:34:33 PST
WebKit exposes a page setting to enable and disable composited layer borders for debugging issues with accelerated compositing. It would be useful to expose this setting so that Epiphany can use it.
------- Comment #1 From 2012-05-21 16:33:41 PST -------
Created an attachment (id=143132) [details]
Patch
------- Comment #2 From 2012-05-21 16:36:00 PST -------
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
------- Comment #3 From 2012-05-21 23:19:59 PST -------
(From update of attachment 143132 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=143132&action=review

Looks good! Please add a test case to the WebKitSettings unit test too.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:919
> +     * WebKitSettings:draw-compositing-indicators

Missing trailing : there
------- Comment #4 From 2012-05-21 23:48:29 PST -------
(From update of attachment 143132 [details])
Attachment 143132 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12748323
------- Comment #5 From 2012-05-22 11:15:52 PST -------
Created an attachment (id=143329) [details]
Patch with unit test and doc fix
------- Comment #6 From 2012-05-22 23:34:22 PST -------
(From update of attachment 143329 [details])
LGTM!
------- Comment #7 From 2012-05-23 09:06:20 PST -------
(From update of attachment 143329 [details])
Clearing flags on attachment: 143329

Committed r118183: <http://trac.webkit.org/changeset/118183>
------- Comment #8 From 2012-05-23 09:06:25 PST -------
All reviewed patches have been landed.  Closing bug.