Bug 87046 – [chromium] Port chromium compositor to use WebFilterOperation(s)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Port chromium compositor to use WebFilterOperation(s)

[James Robinson]

Created attachment 143103 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adrienne Walker]

Comment on attachment 143103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143103&action=review

R=me.  This is a huge patch, but really straightforward.  How are you handling the Chromium side of this?

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:327
> +    if (!backgroundFilters.isEmpty())
> +        CCLayerTreeHost::setNeedsFilterContext(true);

Ack, nice catch.

> Source/WebCore/platform/graphics/chromium/LayerChromium.h:57
> +

nit: needless whitespace

[James Robinson]

There's one caller chromium-side that will break with this.  I think I'll add a #define in WebFilterOperation.h, wrap the chromium side with #ifdefs, land the chromium patch, then land this patch, then remove chromium #ifdefs, then remove the #define.

[James Robinson]

Proposed guard:


diff --git a/Source/Platform/chromium/public/WebFilterOperation.h b/Source/Platform/chromium/public/WebFilterOperation.h
index e1c8270..039f729 100644
--- a/Source/Platform/chromium/public/WebFilterOperation.h
+++ b/Source/Platform/chromium/public/WebFilterOperation.h
@@ -65,6 +65,7 @@ public:
         return m_dropShadowColor;
     }
 
+#define WEBKIT_HAS_NEW_WEBFILTEROPERATION_API 1
     static WebFilterOperation createGrayscaleFilter(float amount) { return WebFilterOperation(FilterTypeGrayscale, amount); }
     static WebFilterOperation createSepiaFilter(float amount) { return WebFilterOperation(FilterTypeSepia, amount); }
     static WebFilterOperation createSaturateFilter(float amount) { return WebFilterOperation(FilterTypeSaturate, amount); }


and chromium-side patch:
https://chromiumcodereview.appspot.com/10414030/

sound good?

[Adrienne Walker]

Looks good to me.

[James Robinson]

Committed r117864: <http://trac.webkit.org/changeset/117864>