Bug 87040 - Change RenderBlock to user RenderBox/RenderInline writing mode logic
Summary: Change RenderBlock to user RenderBox/RenderInline writing mode logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 85824
  Show dependency tree / graph
 
Reported: 2012-05-21 12:53 PDT by Emil A Eklund
Modified: 2012-05-22 04:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.63 KB, patch)
2012-05-21 12:57 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (17.70 KB, patch)
2012-05-22 01:12 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (17.73 KB, patch)
2012-05-22 02:38 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-05-21 12:53:56 PDT 
Remove unnecessary writing mode logic in RenderBlock and use the implementation in RenderBox and RenderInline instead.
Comment 1 Emil A Eklund 2012-05-21 12:57:12 PDT 
Created attachment 143081 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-21 16:08:11 PDT 
Comment on attachment 143081 [details]
Patch

I might have named it "overrideStyle" instead of otherStyle.  This seems OK.  the usingStyle(style) pattern would be fine to.
Comment 3 Emil A Eklund 2012-05-22 01:12:31 PDT 
Created attachment 143219 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-05-22 01:58:12 PDT 
Comment on attachment 143219 [details]
Patch for landing

Rejecting attachment 143219 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
re::RenderStyle*)':
Source/WebCore/rendering/RenderBox.cpp:171: error: 'otherStyle' was not declared in this scope
Source/WebCore/rendering/RenderBox.cpp: In member function 'void WebCore::RenderBox::setMarginAfter(WebCore::LayoutUnit, const WebCore::RenderStyle*)':
Source/WebCore/rendering/RenderBox.cpp:189: error: 'otherStyle' was not declared in this scope
make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/RenderBox.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/12730937
Comment 5 Emil A Eklund 2012-05-22 02:38:43 PDT 
Created attachment 143243 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-05-22 04:15:34 PDT 
Comment on attachment 143243 [details]
Patch for landing

Clearing flags on attachment: 143243

Committed r117946: <http://trac.webkit.org/changeset/117946>
Comment 7 WebKit Review Bot 2012-05-22 04:15:39 PDT 
All reviewed patches have been landed.  Closing bug.