Bug 87027 - Cleanup of Calls to operationStrCat and operationNewArray and Use Constructor after r117729
Summary: Cleanup of Calls to operationStrCat and operationNewArray and Use Constructor...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Michael Saboff
Depends on:
Reported: 2012-05-21 10:13 PDT by Michael Saboff
Modified: 2012-05-21 17:48 PDT (History)
0 users

See Also:

Patch (3.98 KB, patch)
2012-05-21 10:42 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Updated Patch with create() addition (5.65 KB, patch)
2012-05-21 17:06 PDT, Michael Saboff
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-05-21 10:13:06 PDT
The DFS JIT code that generates calls to operationStrCat and operationNewArray should directly provide the data buffer instead of providing the ScratchBuffer pointer.  This would eliminate the need for operationStrCat and operationNewArray from having to call dataBuffer() on the ScratchBuffer object.
Comment 1 Michael Saboff 2012-05-21 10:42:43 PDT
Created attachment 143057 [details]
Comment 2 Michael Saboff 2012-05-21 16:57:10 PDT
Comment #15 from https://bugs.webkit.org/show_bug.cgi?id=86553 after the change set landed suggests that we should add a create() method and use the constructor for ScratchBuffer.
Comment 3 Michael Saboff 2012-05-21 17:06:57 PDT
Created attachment 143140 [details]
Updated Patch with create() addition
Comment 4 Michael Saboff 2012-05-21 17:48:47 PDT
Committed r117860: <http://trac.webkit.org/changeset/117860>