Bug 87022 - Web Inspector: switch buildDominatedNodes function to front-end calculated _dominatorsTree
Summary: Web Inspector: switch buildDominatedNodes function to front-end calculated _d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 87089
  Show dependency treegraph
 
Reported: 2012-05-21 08:40 PDT by Ilya Tikhonovsky
Modified: 2012-05-22 00:01 PDT (History)
10 users (show)

See Also:


Attachments
Patch (7.47 KB, patch)
2012-05-21 08:47 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-21 08:40:00 PDT
%subj%

RESULT heap-snapshot: _buildDominatedNodes= 135 ms
vs
RESULT heap-snapshot: _buildDominatedNodes= 31 ms
Comment 1 Ilya Tikhonovsky 2012-05-21 08:47:52 PDT
Created attachment 143043 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-21 08:51:14 PDT
Comment on attachment 143043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143043&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:-722
> -        if (this._dominatorOffset !== -1) // For tests where we may not have dominator field.

Please make sure that it doesn't break tests.
Comment 3 Ilya Tikhonovsky 2012-05-21 09:01:25 PDT
Committed r117786: <http://trac.webkit.org/changeset/117786>