Bug 87020 – run-webkit-tests fails when svn is not installed

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Lauro Moura Maranhao Neto]

Revision 117643 added a call to the svn executable without a try/except guard to avoid raising the exception when svn is not installed.

[Lauro Moura Maranhao Neto]

Created attachment 143033 [details]
Adds try/except guard around the svn call

[Adam Barth]

Comment on attachment 143033 [details]
Adds try/except guard around the svn call

Can we test this change?

[Ryosuke Niwa]

Comment on attachment 143033 [details]
Adds try/except guard around the svn call

View in context: https://bugs.webkit.org/attachment.cgi?id=143033&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:97
> +        try:
> +            exit_code = Executive().run_command(svn_info_args, cwd=path, return_exit_code=True)
> +            return (exit_code == 0)
> +        except OSError:
> +            return False

We need a test for this. r- due to the lack of a test.

[Rafael Brandao]

I confirm this bug (spent some time to figure out the lack of subversion).
Could we at least print a more meaningful message when this error shows up?

[Rafael Brandao]

On a side note, it also fails when xvfb is missing:

(...)
  File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 220, in run_test
    return self._running_drivers[cmd_line_key].run_test(driver_input)
  File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 558, in run_test
    self.start(driver_input.should_run_pixel_test, driver_input.args)
  File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 670, in start
    self._start(pixel_tests, per_test_args)
  File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py", line 59, in _start
    self._xvfb_process = subprocess.Popen(run_xvfb, stderr=devnull)
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

[Rafael Brandao]

*** This bug has been marked as a duplicate of bug 76630 ***