Bug 87018 – [EFL] fast/forms/input-text-drag-down test failure

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Jussi Kukkonen (jku)]

fast/forms/input-text-drag-down.html test fails because the click registers at the "top area" of the input element resulting in focus moving to the start (and not to the horizontal position of the click). Moving the initial click position in the test just 1 px down will give a correct result (selection will start at position 5 instead of 0).

Is this a bug in the input element in efl port or should the test be modified to allow what the efl port input element does?

[Jussi Kukkonen (jku)]

Created attachment 143277 [details]
Patch

Looking at the entry rendering it looks like there could be too much padding on top (there's definitely more padding above the cursor than below). With that assumption, here's a patch to decrease entry top padding by 1px.

[Raphael Kubo da Costa (:rakuco)]

Looks good. It hasn't caused regressions in other form-related tests, right?

[Gyuyoung Kim]

As kubo asked, if there are no regression fails, looks good to me as well.

[Jussi Kukkonen (jku)]

Hmm, I do see regressions now (apparently I didn't actually run the tests yesterday like I thought I did). I'll take a closer look.

[Jussi Kukkonen (jku)]

(In reply to comment #4)
> Hmm, I do see regressions now (apparently I didn't actually run the tests 
> yesterday like I thought I did). I'll take a closer look.

That wasn't very accurate... I tried to say: I do see some unexpected regressions.

These unexpected regressions disappeard with a small tweak (actually moving the renderblock for text_confinement upwards instead of increasing the size as the currently attached patch does). There are still actual test result changes (maybe two dozen tests) as the renderblock is moved one pixel up.

I'll prepare a patch with *-expected.* changes as well so you see what I mean.

[Gyuyoung Kim]

Comment on attachment 143277 [details]
Patch

Cleared review? from attachment 143277 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.