RESOLVED FIXED 87013
[Qt] Mini clean ups in the interaction engine 
https://bugs.webkit.org/show_bug.cgi?id=87013
Summary [Qt] Mini clean ups in the interaction engine
Kenneth Rohde Christiansen
Reported 2012-05-21 06:15:36 PDT
SSIA
Attachments
Patch (3.18 KB, patch)
2012-05-21 06:16 PDT, Kenneth Rohde Christiansen 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-05-21 06:16:51 PDT
Created attachment 143017 [details] Patch
zalan
Comment 2 2012-05-21 07:13:56 PDT
a little bit unrelated but since you are touching animateItemRectVisible(): it looks like after a few refactorings, it does not need to be public method anymore (neither it's pair setItemRectVisible()) Could you commit them as private, unless there's a good reason to still have them around as public?
Simon Hausmann
Comment 3 2012-05-22 02:43:39 PDT
Comment on attachment 143017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143017&action=review I'll have to trust you on the logic and welcome any change that adds test coverage to those magic if statements ;-) > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:191 > + ASSERT(m_suspended); I bet Zalan is going to run into this one ;) > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:618 > + * FIXME: This is currently called twise if you concurrently change width and height. twise -> twice
Kenneth Rohde Christiansen
Comment 4 2012-05-22 04:55:00 PDT
Landed in 117952 Sure Zalan will run into the assert :-) that is why we add them!
zalan
Comment 5 2012-05-22 05:29:28 PDT
(In reply to comment #4) > Landed in 117952 > > Sure Zalan will run into the assert :-) that is why we add them! and i am so grateful for that.
Note You need to log in before you can comment on or make changes to this bug.