Created attachment 143017 [details]
a little bit unrelated but since you are touching animateItemRectVisible(): it looks like after a few refactorings, it does not need to be public method anymore (neither it's pair setItemRectVisible()) Could you commit them as private, unless there's a good reason to still have them around as public?
Comment on attachment 143017 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=143017&action=review
I'll have to trust you on the logic and welcome any change that adds test coverage to those magic if statements ;-)
> + ASSERT(m_suspended);
I bet Zalan is going to run into this one ;)
> + * FIXME: This is currently called twise if you concurrently change width and height.
twise -> twice
Landed in 117952
Sure Zalan will run into the assert :-) that is why we add them!
(In reply to comment #4)
> Landed in 117952
> Sure Zalan will run into the assert :-) that is why we add them!
and i am so grateful for that.