Bug 87007 – Web Inspector: Fix spacing on Settings screen and Shortcuts screen.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Created attachment 142998 [details]
Screenshot: fixed Settings screen

Checkbox seems to be improperly aligned. It is "shifted" up on 1px on Mac and 2px on Linux.

Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

Created attachment 142999 [details]
Screenshot: fixed keyboard shortcuts screen

Created attachment 143001 [details]
Screenshot: misaligned checkboxes in settings

Created attachment 143002 [details]
Screenshot: wrapped keyboard shortcuts

Created attachment 143006 [details]
Patch

[Early Warning System Bot]

Comment on attachment 143006 [details]
Patch

Attachment 143006 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12732614

[Csaba Osztrogonác]

(In reply to comment #5)
> (From update of attachment 143006 [details])
> Attachment 143006 [details] did not pass qt-ews (qt):
> Output: http://queues.webkit.org/results/12732614

Sorry, it was false positive alarm.

[Pavel Feldman]

Comment on attachment 143006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143006&action=review

> Source/WebCore/inspector/front-end/helpScreen.css:125
> +    -webkit-column-width: 470px;

Why do we need so many non-mac specifics? I thought this patch was about the checkboxes align.

(In reply to comment #7)
> (From update of attachment 143006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143006&action=review
> 
> > Source/WebCore/inspector/front-end/helpScreen.css:125
> > +    -webkit-column-width: 470px;
> 
> Why do we need so many non-mac specifics? I thought this patch was about the checkboxes align.

I've noticed severe spacing issue on shortcuts screen and fixed it alongside with checkbox alignment (please see screenshots and description).

I'll change bug title.

About non-mac specific: what is preferable?:
 1) override values from general rules with mac-specific values
 2) explicitly specify platform-dependent values in distinct rules.

If first, I'll revert these "non-mac" rules.

[Pavel Feldman]

> About non-mac specific: what is preferable?:
>  1) override values from general rules with mac-specific values
>  2) explicitly specify platform-dependent values in distinct rules.
> 
> If first, I'll revert these "non-mac" rules.

Why is Mac so different? I was under the impression that web is the same for everybody :)

(In reply to comment #9)
> > About non-mac specific: what is preferable?:
> >  1) override values from general rules with mac-specific values
> >  2) explicitly specify platform-dependent values in distinct rules.
> > 
> > If first, I'll revert these "non-mac" rules.
> 
> Why is Mac so different? I was under the impression that web is the same for everybody :)

Mac has times more compact (but less readable) shortcuts visualization.
That is why user sees a lot of empty space to the left of shortcuts column.

Also, Inspector uses another font on Mac (and font metrics differ from non-mac font metrics).

Created attachment 143279 [details]
Patch

(In reply to comment #0)
> Created an attachment (id=142998) [details]
> Screenshot: fixed Settings screen
> 
> Checkbox seems to be improperly aligned. It is "shifted" up on 1px on Mac and 2px on Linux.
> 
> Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

Radio controls are also "shifted" up on 1px on Mac and 2px on Linux.

Created attachment 145070 [details]
Patch

Rebased.
+fixed spacing between close button and tabs on mac

[Andrey Kosyakov]

Committed r119099: <http://trac.webkit.org/changeset/119099>