Bug 87001 - QtWebkit: handle german umlauts in keyIdentifierForQtKeyCode()
Summary: QtWebkit: handle german umlauts in keyIdentifierForQtKeyCode()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-21 04:15 PDT by Holger Kaelberer
Modified: 2014-12-09 19:00 PST (History)
3 users (show)

See Also:

Attachments
handle german umlauts in keyIdentifierForQtKeyCode() (2.08 KB, patch)
2012-05-21 04:15 PDT, Holger Kaelberer 		no flags Details | Formatted Diff | Diff
corresponding changelog entry (675 bytes, patch)
2012-06-22 04:33 PDT, Holger Kaelberer 		no flags Details | Formatted Diff | Diff
updated changelog patch (642 bytes, patch)
2012-06-22 05:28 PDT, Holger Kaelberer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Kaelberer 2012-05-21 04:15:32 PDT 
Created attachment 142991 [details]
handle german umlauts in keyIdentifierForQtKeyCode()

Currently german umlauts are not mapped correctly to keycodes in key events in QtWebkit classes (keycode=0). Tested on linux. The attached patch fixes this issue for us by adding the missing Qt::Key_* cases in keyIdentifierForQtKeyCode().

Thanks,
 Holger
Comment 1 Bruno Abinader (history only) 2012-06-21 05:47:30 PDT 
Comment on attachment 142991 [details]
handle german umlauts in keyIdentifierForQtKeyCode()

Missing ChangeLog comments. There is a tool that helps a lot on that (Tools/Scripts/prepare-changelog).
Comment 2 Holger Kaelberer 2012-06-22 04:33:36 PDT 
Created attachment 148994 [details]
corresponding changelog entry

Corresponding Changelog entry patch. Used a git checkout this time because svn co ended up with an error.
Comment 3 WebKit Review Bot 2012-06-22 05:21:39 PDT 
Attachment 148994 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog']" exit_code: 1
Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Holger Kaelberer 2012-06-22 05:28:57 PDT 
Created attachment 149002 [details]
updated changelog patch

updated changelog patch
Comment 5 Alexey Proskuryakov 2014-12-09 19:00:48 PST 
The Qt port no longer exists in webkit.org.