Bug 86988 - [EFL] Add inital mediaControlsEflfullscreen.css for fullscreen control UI
Summary: [EFL] Add inital mediaControlsEflfullscreen.css for fullscreen control UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 23:17 PDT by Gyuyoung Kim
Modified: 2012-05-22 09:23 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.95 KB, patch)
2012-05-20 23:24 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-05-20 23:17:44 PDT 
In order to support fullscreen feature, EFL port needs to have new css file for fullscreen media control UI. Initial mediaControlsEflFullscreen.css of this patch is just simple implementation which doesn't influence on existing layout test result first. In future, this css file should be implemented together with updated expected result.
Comment 1 Gyuyoung Kim 2012-05-20 23:24:32 PDT 
Created attachment 142949 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-21 20:29:59 PDT 
Comment on attachment 142949 [details]
Patch

Clearing flags on attachment: 142949

Committed r117890: <http://trac.webkit.org/changeset/117890>
Comment 3 WebKit Review Bot 2012-05-21 20:30:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Thiago Marcos P. Santos 2012-05-22 03:30:46 PDT 
These tests are flaky after this patch:

media/video-controls-rendering.html = TEXT PASS
media/video-display-toggle.html = TEXT PASS
media/video-empty-source.html = TEXT PASS
media/video-zoom-controls.html = TEXT PASS
Comment 5 Gyuyoung Kim 2012-05-22 03:46:14 PDT 
(In reply to comment #4)
> These tests are flaky after this patch:
> 
> media/video-controls-rendering.html = TEXT PASS
> media/video-display-toggle.html = TEXT PASS
> media/video-empty-source.html = TEXT PASS
> media/video-zoom-controls.html = TEXT PASS

I'm sorry, could you please rebaseline for those tests ?
Comment 6 Thiago Marcos P. Santos 2012-05-22 09:23:12 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > These tests are flaky after this patch:
> > 
> > media/video-controls-rendering.html = TEXT PASS
> > media/video-display-toggle.html = TEXT PASS
> > media/video-empty-source.html = TEXT PASS
> > media/video-zoom-controls.html = TEXT PASS
> 
> I'm sorry, could you please rebaseline for those tests ?

Fixed on bug 87138.