WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86988
[EFL] Add inital mediaControlsEflfullscreen.css for fullscreen control UI
https://bugs.webkit.org/show_bug.cgi?id=86988
Summary
[EFL] Add inital mediaControlsEflfullscreen.css for fullscreen control UI
Gyuyoung Kim
Reported
2012-05-20 23:17:44 PDT
In order to support fullscreen feature, EFL port needs to have new css file for fullscreen media control UI. Initial mediaControlsEflFullscreen.css of this patch is just simple implementation which doesn't influence on existing layout test result first. In future, this css file should be implemented together with updated expected result.
Attachments
Patch
(7.95 KB, patch)
2012-05-20 23:24 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2012-05-20 23:24:32 PDT
Created
attachment 142949
[details]
Patch
WebKit Review Bot
Comment 2
2012-05-21 20:29:59 PDT
Comment on
attachment 142949
[details]
Patch Clearing flags on attachment: 142949 Committed
r117890
: <
http://trac.webkit.org/changeset/117890
>
WebKit Review Bot
Comment 3
2012-05-21 20:30:05 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 4
2012-05-22 03:30:46 PDT
These tests are flaky after this patch: media/video-controls-rendering.html = TEXT PASS media/video-display-toggle.html = TEXT PASS media/video-empty-source.html = TEXT PASS media/video-zoom-controls.html = TEXT PASS
Gyuyoung Kim
Comment 5
2012-05-22 03:46:14 PDT
(In reply to
comment #4
)
> These tests are flaky after this patch: > > media/video-controls-rendering.html = TEXT PASS > media/video-display-toggle.html = TEXT PASS > media/video-empty-source.html = TEXT PASS > media/video-zoom-controls.html = TEXT PASS
I'm sorry, could you please rebaseline for those tests ?
Thiago Marcos P. Santos
Comment 6
2012-05-22 09:23:12 PDT
(In reply to
comment #5
)
> (In reply to
comment #4
) > > These tests are flaky after this patch: > > > > media/video-controls-rendering.html = TEXT PASS > > media/video-display-toggle.html = TEXT PASS > > media/video-empty-source.html = TEXT PASS > > media/video-zoom-controls.html = TEXT PASS > > I'm sorry, could you please rebaseline for those tests ?
Fixed on
bug 87138
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug