Bug 86982 – [EFL] Do not enable Web Audio support by default at build time.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Raphael Kubo da Costa (:rakuco)]

[EFL] Do not enable Web Audio support by default at build time.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 142937 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 142937 [details]
Patch

Looks fine.

[Philippe Normand]

Comment on attachment 142937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review

> ChangeLog:13
> +        Since Web Audio support for the EFL port does not seem to be fully
> +        working yet, it is better to disable it in all cases.

I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #3)
> (From update of attachment 142937 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review
> 
> > ChangeLog:13
> > +        Since Web Audio support for the EFL port does not seem to be fully
> > +        working yet, it is better to disable it in all cases.
> 
> I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187

Probably that. I tried running the webaudio/ layout tests with web audio support enabled and they did not work. Then looking at the commit which added web audio support for the EFL port I noticed this build system inconsistency.

[WebKit Review Bot]

Comment on attachment 142937 [details]
Patch

Clearing flags on attachment: 142937

Committed r117807: <http://trac.webkit.org/changeset/117807>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.