Bug 86982 - [EFL] Do not enable Web Audio support by default at build time.
Summary: [EFL] Do not enable Web Audio support by default at build time.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 20:22 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-21 12:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-05-20 20:25 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-05-20 20:22:51 PDT
[EFL] Do not enable Web Audio support by default at build time.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-20 20:25:44 PDT
Created attachment 142937 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-21 04:30:08 PDT
Comment on attachment 142937 [details]
Patch

Looks fine.
Comment 3 Philippe Normand 2012-05-21 11:45:02 PDT
Comment on attachment 142937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review

> ChangeLog:13
> +        Since Web Audio support for the EFL port does not seem to be fully
> +        working yet, it is better to disable it in all cases.

I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-21 11:57:07 PDT
(In reply to comment #3)
> (From update of attachment 142937 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review
> 
> > ChangeLog:13
> > +        Since Web Audio support for the EFL port does not seem to be fully
> > +        working yet, it is better to disable it in all cases.
> 
> I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187

Probably that. I tried running the webaudio/ layout tests with web audio support enabled and they did not work. Then looking at the commit which added web audio support for the EFL port I noticed this build system inconsistency.
Comment 5 WebKit Review Bot 2012-05-21 12:23:53 PDT
Comment on attachment 142937 [details]
Patch

Clearing flags on attachment: 142937

Committed r117807: <http://trac.webkit.org/changeset/117807>
Comment 6 WebKit Review Bot 2012-05-21 12:23:58 PDT
All reviewed patches have been landed.  Closing bug.