Bug 86970 - Move padding/margin/offset writing mode logic from RenderStyle to LengthBox
Summary: Move padding/margin/offset writing mode logic from RenderStyle to LengthBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 13:30 PDT by Emil A Eklund
Modified: 2012-05-21 16:42 PDT (History)
5 users (show)

See Also:


Attachments
Patch (19.70 KB, patch)
2012-05-20 13:38 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-05-20 13:30:41 PDT
RenderStyle currently has a lot of logic for translating before/after/start/end to top/bottom/left/right for paddings, margins, borders and offsets. Move this logic to LengthBox and make paddings/margins/offsets use the same implementation.
Comment 1 Emil A Eklund 2012-05-20 13:38:29 PDT
Created attachment 142915 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-21 16:06:25 PDT
Comment on attachment 142915 [details]
Patch

Again, same possible perf considerations, but another huge cleanliness win.  We'll see!
Comment 3 WebKit Review Bot 2012-05-21 16:42:10 PDT
Comment on attachment 142915 [details]
Patch

Clearing flags on attachment: 142915

Committed r117832: <http://trac.webkit.org/changeset/117832>
Comment 4 WebKit Review Bot 2012-05-21 16:42:14 PDT
All reviewed patches have been landed.  Closing bug.