RESOLVED FIXED 86966
Web Inspector: implement revision history view.
https://bugs.webkit.org/show_bug.cgi?id=86966
Summary Web Inspector: implement revision history view.
Pavel Feldman
Reported 2012-05-20 10:46:00 PDT
Added revision view into the drawer. It now lists all the revisions along with the inline diffs. Once source panel is enabled by default, this view will complete substitute the one in the resources panel. See the screenshot attached.
Attachments
[IMAGE] Screenshot with patch applied. (86.92 KB, image/png)
2012-05-20 10:46 PDT, Pavel Feldman
no flags
Patch (31.72 KB, patch)
2012-05-20 10:56 PDT, Pavel Feldman
yurys: review+
Pavel Feldman
Comment 1 2012-05-20 10:46:19 PDT
Created attachment 142906 [details] [IMAGE] Screenshot with patch applied.
Pavel Feldman
Comment 2 2012-05-20 10:56:25 PDT
Yury Semikhatsky
Comment 3 2012-05-21 01:18:27 PDT
Comment on attachment 142907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142907&action=review > Source/WebCore/inspector/front-end/ContextMenu.js:115 > +WebInspector.ContextMenu.Provider.prototype = { It should probably be merged with WebInspector.ObjectPropertiesSection.ContextMenuProvider > Source/WebCore/inspector/front-end/RevisionHistoryView.js:210 > + Can we have a test for this algorithm?
Pavel Feldman
Comment 4 2012-05-21 01:39:33 PDT
> Can we have a test for this algorithm? I'll extract it and add tests as a separate change.
Pavel Feldman
Comment 5 2012-05-21 01:55:14 PDT
Note You need to log in before you can comment on or make changes to this bug.