Bug 86966 - Web Inspector: implement revision history view.
Summary: Web Inspector: implement revision history view.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-05-20 10:46 PDT by Pavel Feldman
Modified: 2012-05-21 01:55 PDT (History)
10 users (show)

See Also:

[IMAGE] Screenshot with patch applied. (86.92 KB, image/png)
2012-05-20 10:46 PDT, Pavel Feldman
no flags Details
Patch (31.72 KB, patch)
2012-05-20 10:56 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-05-20 10:46:00 PDT
Added revision view into the drawer. It now lists all the revisions along with the inline diffs. Once source panel is enabled by default, this view will complete substitute the one in the resources panel. See the screenshot attached.
Comment 1 Pavel Feldman 2012-05-20 10:46:19 PDT
Created attachment 142906 [details]
[IMAGE] Screenshot with patch applied.
Comment 2 Pavel Feldman 2012-05-20 10:56:25 PDT
Created attachment 142907 [details]
Comment 3 Yury Semikhatsky 2012-05-21 01:18:27 PDT
Comment on attachment 142907 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=142907&action=review

> Source/WebCore/inspector/front-end/ContextMenu.js:115
> +WebInspector.ContextMenu.Provider.prototype = {

It should probably be merged with WebInspector.ObjectPropertiesSection.ContextMenuProvider

> Source/WebCore/inspector/front-end/RevisionHistoryView.js:210
> +

Can we have a test for this algorithm?
Comment 4 Pavel Feldman 2012-05-21 01:39:33 PDT
> Can we have a test for this algorithm?

I'll extract it and add tests as a separate change.
Comment 5 Pavel Feldman 2012-05-21 01:55:14 PDT
Committed r117750: <http://trac.webkit.org/changeset/117750>