Bug 86962 – [GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mikhail Pozdnyakov]

In order to be consistent with other Webkit ports GTK's LayoutTestController::setCacheModel(int cacheModel) should set WEBKIT_CACHE_MODEL_WEB_BROWSER if cacheModel is equal to 3, currently sets WEBKIT_CACHE_MODEL_DOCUMENT_BROWSER.

[Mikhail Pozdnyakov]

Created attachment 142897 [details]
patch

[Mikhail Pozdnyakov]

Created attachment 142898 [details]
patch v2 (fixed bug title changelog)

[Gustavo Noronha (kov)]

Comment on attachment 142898 [details]
patch v2 (fixed bug title changelog)

View in context: https://bugs.webkit.org/attachment.cgi?id=142898&action=review

> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:655
>      case 3:
> -        webkit_set_cache_model(WEBKIT_CACHE_MODEL_DOCUMENT_BROWSER);
> +        webkit_set_cache_model(WEBKIT_CACHE_MODEL_WEB_BROWSER);

Your change looks right to me, but... that case should be 2 not 3, and 2 should be falling down to the ASSERT_NOT_REACHED(), so I'm wondering if this is used at all. Hah, it's not used indeed:

kov@goiaba ~/s/W/LayoutTests> git grep setCacheModel
fast/dom/HTMLScriptElement/nested-execution.html:                layoutTestController.setCacheModel(0); // WebCacheModelDocumentViewer
platform/chromium/test_expectations.txt:// This test requires LayoutTestController.setCacheModel, which we don't
platform/efl/Skipped:# EFL's LayoutTestController does not implement setCacheModel
platform/wk2/Skipped:# WebKitTestRunner needs layoutTestController.setCacheModel

Please fix the case too.

[Mikhail Pozdnyakov]

Created attachment 143211 [details]
patch v3 (fixed case also)

[Mikhail Pozdnyakov]

(In reply to comment #3)
> Please fix the case too.
Wow! I did not noticed that issue.. Thanks for review.

[WebKit Review Bot]

Comment on attachment 143211 [details]
patch v3 (fixed case also)

Clearing flags on attachment: 143211

Committed r118007: <http://trac.webkit.org/changeset/118007>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.