There should be an api setting page cache capacity, so that a client can improve document load speed substantially by caching a large number previously viewed pages or reduce memory usage decreasing the size of page cache. This setting is exported in other WebKit ports (Qt, GTK, MAC) either as a separate setting or as a part of caching model.
Created attachment 142901 [details] patch
Comment on attachment 142901 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=142901&action=review The addition itself looks fine, but you should mention what the default is. BTW, _ewk_init_body() calls setCapacity() directly, you might want to route that call via ewk_settings now. > Source/WebKit/efl/ChangeLog:9 > + Those will be used both by clients ant DRT Layout Test Controller. Nitpick: s/ant/and/. > Source/WebKit/efl/ewk/ewk_settings.h:302 > + * The page cache improves user experience when navigating forth or back > + * to pages in the forward/back history. It'd be good to describe how it achieves this improvement: what does it cache, for example? > Source/WebKit/efl/ewk/ewk_settings.h:306 > +EAPI unsigned ewk_settings_page_cache_capacity_get(); This is a public header used by C applications, so you need to use foo(void) instead of foo().
Created attachment 143021 [details] patch v2 (fixed api description, typo in changelog, efl wrapper is used in _ewk_init_body)
(In reply to comment #2) > (From update of attachment 142901 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142901&action=review > > The addition itself looks fine, but you should mention what the default is. BTW, _ewk_init_body() calls setCapacity() directly, you might want to route that call via ewk_settings now. > > > Source/WebKit/efl/ChangeLog:9 > > + Those will be used both by clients ant DRT Layout Test Controller. > > Nitpick: s/ant/and/. > > > Source/WebKit/efl/ewk/ewk_settings.h:302 > > + * The page cache improves user experience when navigating forth or back > > + * to pages in the forward/back history. > > It'd be good to describe how it achieves this improvement: what does it cache, for example? > > > Source/WebKit/efl/ewk/ewk_settings.h:306 > > +EAPI unsigned ewk_settings_page_cache_capacity_get(); > > This is a public header used by C applications, so you need to use foo(void) instead of foo(). Thanks for review. Fixed in https://bugs.webkit.org/attachment.cgi?id=143021.
Comment on attachment 143021 [details] patch v2 (fixed api description, typo in changelog, efl wrapper is used in _ewk_init_body) Looks good, thank you.
Comment on attachment 143021 [details] patch v2 (fixed api description, typo in changelog, efl wrapper is used in _ewk_init_body) rs=me.
Comment on attachment 143021 [details] patch v2 (fixed api description, typo in changelog, efl wrapper is used in _ewk_init_body) Clearing flags on attachment: 143021 Committed r117785: <http://trac.webkit.org/changeset/117785>
All reviewed patches have been landed. Closing bug.