Bug 86949 – AX: A disabled select element should not be exposed as focusable

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Dominic Mazzoni]

Test html: <select disabled><option>1<option>2</select>

The AccessibilityObject associated with the control has role PopUpButtonRole, and correctly returns false for isEnabled(), but incorrectly returns true for canSetFocusAttribute() even though it can't be focused.

The other form controls I checked behave correctly - if isEnabled() is false, canSetFocusAttribute() returns false. Should be a simple fix - it looks like AccessibilityMenuList.h has canSetFocusAttribute() always return true, but actually it should return false if the control isn't enabled.

[Alice Boxhall]

I wonder whether this is related to bug 76119.

[Dominic Mazzoni]

Created attachment 143041 [details]
Patch

[chris fleizach]

Comment on attachment 143041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143041&action=review

you have some failures in your tests

> Source/WebCore/accessibility/AccessibilityListBox.cpp:74
> +    return static_cast<Element*>(node())->isEnabledFormControl();

might be nice to add a comment why the default AccessibilityRenderObject::canSetFocus does not work for this kind of control

[WebKit Review Bot]

Comment on attachment 143041 [details]
Patch

Attachment 143041 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12734652

New failing tests:
accessibility/disabled-controls-not-focusable.html

[WebKit Review Bot]

Created attachment 143044 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dominic Mazzoni]

(In reply to comment #3)
> might be nice to add a comment why the default AccessibilityRenderObject::canSetFocus does not work for this kind of control

You're right - the default implementation works fine for ListBox (but not for MenuList). A better fix is to just remove the override.

Test expectations should be correct now.

[Dominic Mazzoni]

Created attachment 143051 [details]
Patch

[chris fleizach]

Comment on attachment 143051 [details]
Patch

looks good

[WebKit Review Bot]

Comment on attachment 143051 [details]
Patch

Clearing flags on attachment: 143051

Committed r117803: <http://trac.webkit.org/changeset/117803>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.