Bug 86946 - [EFL] Implement PlatformStrategies
Summary: [EFL] Implement PlatformStrategies
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
: 89063 (view as bug list)
Depends on:
Reported: 2012-05-19 12:05 PDT by Sudarsana Nagineni (babu)
Modified: 2012-06-14 00:01 PDT (History)
9 users (show)

See Also:

Patch (15.29 KB, patch)
2012-05-24 08:36 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-05-19 12:05:39 PDT
Add support/enable PLATFORM_STRATEGIES in the EFL port. Many ports already supports PlatformStrategies and we will need them for WebKit2.

reference: https://lists.webkit.org/pipermail/webkit-dev/2010-June/013270.html
Comment 1 Sudarsana Nagineni (babu) 2012-05-24 08:36:03 PDT
Created attachment 143836 [details]

Turn on PLATFORM_STRATEGIES for EFL platform.
Comment 2 Ryuan Choi 2012-05-30 01:02:25 PDT
(In reply to comment #1)
> Created an attachment (id=143836) [details]
> Patch
> Turn on PLATFORM_STRATEGIES for EFL platform.

Looks good to me.
Comment 3 Gyuyoung Kim 2012-05-30 01:12:55 PDT
Looks fine. CC'ing Mariusz.
Comment 4 WebKit Review Bot 2012-06-01 03:45:39 PDT
Comment on attachment 143836 [details]

Clearing flags on attachment: 143836

Committed r119208: <http://trac.webkit.org/changeset/119208>
Comment 5 WebKit Review Bot 2012-06-01 03:45:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-06-01 06:44:55 PDT
Comment on attachment 143836 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=143836&action=review

> Source/WebCore/PlatformEfl.cmake:87
> +  platform/PlatformStrategies.cpp

One small post-mortem nitpick here is that casing matters in the sorting here, so in the future please consider that 'P' < 'n'.
Comment 7 KwangYong Choi 2012-06-14 00:01:30 PDT
*** Bug 89063 has been marked as a duplicate of this bug. ***