Bug 86937 - Web Inspector: make search results view more dense
: Web Inspector: make search results view more dense
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-18 23:16 PDT by Pavel Feldman
Modified: 2012-05-21 01:35 PDT (History)
10 users (show)

See Also:


Attachments
[IMAGE] Screenshot with patch applied. (129.83 KB, image/png)
2012-05-18 23:18 PDT, Pavel Feldman
no flags Details
Patch (6.31 KB, patch)
2012-05-18 23:23 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (7.48 KB, patch)
2012-05-19 00:55 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] Same with closing search on panel switch (8.76 KB, patch)
2012-05-19 01:37 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[IMAGE] Screenshot with patch applied including new close button. (66.93 KB, image/png)
2012-05-19 03:07 PDT, Pavel Feldman
no flags Details
Patch (11.73 KB, patch)
2012-05-19 03:08 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] Same with onclose notification (16.23 KB, patch)
2012-05-19 06:00 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-05-18 23:16:52 PDT
See the screenshot.
Comment 1 Pavel Feldman 2012-05-18 23:18:46 PDT
Created attachment 142852 [details]
[IMAGE] Screenshot with patch applied.
Comment 2 Pavel Feldman 2012-05-18 23:23:45 PDT
Created attachment 142853 [details]
Patch
Comment 3 Pavel Feldman 2012-05-19 00:55:27 PDT
Created attachment 142855 [details]
Patch
Comment 4 Pavel Feldman 2012-05-19 01:37:45 PDT
Created attachment 142857 [details]
[Patch] Same with closing search on panel switch
Comment 5 Pavel Feldman 2012-05-19 03:07:28 PDT
Created attachment 142859 [details]
[IMAGE] Screenshot with patch applied including new close button.
Comment 6 Pavel Feldman 2012-05-19 03:08:43 PDT
Created attachment 142860 [details]
Patch
Comment 7 Pavel Feldman 2012-05-19 06:00:39 PDT
Created attachment 142864 [details]
[Patch] Same with onclose notification
Comment 8 Yury Semikhatsky 2012-05-21 00:11:33 PDT
Comment on attachment 142864 [details]
[Patch] Same with onclose notification

View in context: https://bugs.webkit.org/attachment.cgi?id=142864&action=review

> Source/WebCore/inspector/front-end/inspector.js:164
> +            document.getElementById("main-status-bar").removeChild(this._drawerStatusBarHeader);

This 5 lines are repeated twice, please extract a method.
Comment 9 Pavel Feldman 2012-05-21 01:35:54 PDT
Committed r117746: <http://trac.webkit.org/changeset/117746>