Bug 86918 - DFG CFG simplification crashes if it's trying to remove an unreachable block that has an already-killed-off unreachable successor
Summary: DFG CFG simplification crashes if it's trying to remove an unreachable block ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 84553
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-18 16:01 PDT by Filip Pizlo
Modified: 2012-05-18 16:20 PDT (History)
0 users

See Also:

Attachments
the patch (1.71 KB, patch)
2012-05-18 16:03 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-05-18 16:01:22 PDT 
We kill off unreachable blocks in arbitrary order. Therefore if there is a network of unreachable blocks, we may try to do unreachable-successor fix-up when the successor has already been deleted. Then we crash.

This is hit by:

inspector/styles/styles-computed-trace.html
inspector/console/console-big-array.html
Comment 1 Filip Pizlo 2012-05-18 16:03:34 PDT 
Created attachment 142810 [details]
the patch
Comment 2 Filip Pizlo 2012-05-18 16:20:12 PDT 
Landed in http://trac.webkit.org/changeset/117654