Bug 86913 – auto margins on flexbox should allocate space in the cross direction

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tony Chang]

See the section here:
http://dev.w3.org/csswg/css3-flexbox/#auto-margins

We're currently treating auto margins as 0.

See also 83086.

[Tony Chang]

Created attachment 143647 [details]
Patch

[Ojan Vafai]

Comment on attachment 143647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143647&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:720
> +        child->setMarginTop(availableAlignmentSpace / 2);
> +        child->setMarginBottom(availableAlignmentSpace / 2);
> +        return true;
> +    }
> +    if (start.isAuto()) {
> +        adjustAlignmentForChild(child, availableAlignmentSpace);
> +        child->setMarginTop(availableAlignmentSpace);
> +        return true;
> +    }
> +    if (end.isAuto()) {
> +        child->setMarginBottom(availableAlignmentSpace);

If we're in a vertical flow, don't we want to be setting marginLeft/marginRight?

[Tony Chang]

Created attachment 143658 [details]
Patch

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 143647 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143647&action=review
> 
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:720
> > +        child->setMarginTop(availableAlignmentSpace / 2);
> > +        child->setMarginBottom(availableAlignmentSpace / 2);
> > +        return true;
> > +    }
> > +    if (start.isAuto()) {
> > +        adjustAlignmentForChild(child, availableAlignmentSpace);
> > +        child->setMarginTop(availableAlignmentSpace);
> > +        return true;
> > +    }
> > +    if (end.isAuto()) {
> > +        child->setMarginBottom(availableAlignmentSpace);
> 
> If we're in a vertical flow, don't we want to be setting marginLeft/marginRight?

Yes, you're right.  Fixed and a test case added in auto-margins.html.

[WebKit Review Bot]

Comment on attachment 143658 [details]
Patch

Clearing flags on attachment: 143658

Committed r118279: <http://trac.webkit.org/changeset/118279>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.