Bug 86904 - Revert to float method of selection rect alignment for line box tree
Summary: Revert to float method of selection rect alignment for line box tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 85555
  Show dependency tree / graph
 
Reported: 2012-05-18 14:46 PDT by Levi Weintraub
Modified: 2012-05-18 16:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2012-05-18 15:46 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-05-18 14:46:39 PDT 
In r117491, we introduced a new method of alignment for the selection rect in the sub-pixel case. It turns out there is at least one case on Mac where this doesn't work with the line box tree. This patch reverts us to the float method for the line box tree, but retains the LayoutRect snapping for gap rects.
Comment 1 Levi Weintraub 2012-05-18 15:46:40 PDT 
Created attachment 142802 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-18 15:54:08 PDT 
Comment on attachment 142802 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2012-05-18 16:57:43 PDT 
Comment on attachment 142802 [details]
Patch

Clearing flags on attachment: 142802

Committed r117659: <http://trac.webkit.org/changeset/117659>
Comment 4 WebKit Review Bot 2012-05-18 16:57:51 PDT 
All reviewed patches have been landed.  Closing bug.