RESOLVED FIXED86892
consider changing the outcome keywords in the expectations file 
https://bugs.webkit.org/show_bug.cgi?id=86892
Summary consider changing the outcome keywords in the expectations file
Dirk Pranke
Reported 2012-05-18 13:26:32 PDT
the current list of outcome keywords are: AUDIO CRASH FAIL IMAGE IMAGE+TEXT PASS TEXT TIMEOUT (I'm ignoring SLOW and REBASELINE; those are separate discussions) To be clear, IMAGE means *just* the PNG fails to match, TEXT means *just* the .txt fails to match, and IMAGE+TEXT means both fail. IMAGE+TEXT does not mean "either is allowed to fail". FAIL is a "legacy" keyword that is interpreted as "any of IMAGE, IMAGE+TEXT, TEXT". It has been suggested -- :) -- that we should use different names and/or a switched to lower or mixed case for the keywords, and that perhaps some of the keywords should be consolidated and/or removed. For the record, I'm okay with (but don't have a strong preference for) switching to lower case depending on what other changes to the syntax of the file occur. I'm not a fan of mixed-case keywords. I have not yet seen any proposals for new keywords I prefer to the existing format.
Attachments
Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-06-21 08:09:36 PDT
Bug 89161 covers the casing questions (TitleCase) that were resolved in http://lists.webkit.org/pipermail/webkit-dev/2012-June/021131.html. This bug should just focus on the naming of the keywords. See http://lists.webkit.org/pipermail/webkit-dev/2012-June/020963.html. The suggestion there is to have: Fail PixelOnlyFail Pass Timeout Crash Fail now encompasses the previous Audio, Image+Text and Text.
Dirk Pranke
Comment 2 2012-09-19 19:08:11 PDT
fixed in bug 89161.
Note You need to log in before you can comment on or make changes to this bug.