Bug 86880 – REGRESSION (r116645): "background-size: auto 100%; width:auto; height:100%;" doesn't display correctly

• Status: RESOLVED
• Resolution: INVALID
• Component: CSS

[Peter Lewis]

Created attachment 142755 [details]
Safari vs Webkit nightly

On http://iam.ptrl.ws/beta.html I'm using width:auto; height:100% to have a 2000x2000px displayed. In Webkit this doesn't display correctly and instead fills the whole browser window.

[Alexey Proskuryakov]

The bug URL is 404 Not Found. Could you please attach your test here?

[Peter Lewis]

Oh I am sorry, I changed my website's URL today! The URL of the page is: 

http://peterlew.is/beta.html

Peter :)

(In reply to comment #1)
> The bug URL is 404 Not Found. Could you please attach your test here?

[Alexey Proskuryakov]

Regressed in <http://trac.webkit.org/changeset/116645>.

[Joe Thomas]

Here is the CSS from the regressed page

   background-size: auto 100%;
   width:auto;
   height:100%;
   background:url(pl_av_cp.jpg) center center no-repeat;

Here background-size is defined before background shorthand.

Since we added background-size to background-shorthand in http://trac.webkit.org/changeset/116645, if background-size is not part of background shorthand, we initialize it with the default value. So this can be solved either by adding background-size to background-shorthand or defining background-size after background.

Peter, Can you please try this out?

[Joe Thomas]

The same issue is mentioned in https://bugs.webkit.org/show_bug.cgi?id=27577#c2

[Alexis Menard (darktears)]

(In reply to comment #4)
> Here is the CSS from the regressed page
> 
>    background-size: auto 100%;
>    width:auto;
>    height:100%;
>    background:url(pl_av_cp.jpg) center center no-repeat;
> 
> Here background-size is defined before background shorthand.
> 
> Since we added background-size to background-shorthand in http://trac.webkit.org/changeset/116645, if background-size is not part of background shorthand, we initialize it with the default value. So this can be solved either by adding background-size to background-shorthand or defining background-size after background.
> 
> Peter, Can you please try this out?

We render the same as FF and Opera now. So it's not really a regression. The behavior we had before was buggy.

[Alexis Menard (darktears)]

Previous behavior was wrong as we :

- Didn't parse the background-size if it was part of the shorthand. We do now.

- Didn't reset the background-size to initial if we don't find it in the shorthand, we do now.


We now behave like the specification : http://www.w3.org/TR/css3-background/#the-background . If a value is missing in a CSS shorthand declaration we should set it to initial which we do now.

[Peter Lewis]

Gosh you guys are quick to respond, thank you.

I've made the adjustments as are recommended and it now renders correctly as can be seen in:

http://peterlew.is/beta2.html

So yes, the resolved/invalid status seems correct, thanks! :)