Bug 86874 - IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
Summary: IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-18 11:12 PDT by Joshua Bell
Modified: 2012-06-06 12:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2012-05-18 13:23 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (5.76 KB, patch)
2012-06-04 11:22 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-05-18 11:12:11 PDT 
The function is non-standard; while proposed, and with some interest from other implementers, it will not be in V1 of the IDB spec. 

While the overall IDB implementation in WebKit is currently prefixed, when we drop the prefix we do not want to introduce a non-prefixed non-standard member.

The patch probably as simple as:

- [CallWith=ScriptExecutionContext] IDBRequest getDatabaseNames();
+ [CallWith=ScriptExecutionContext, ImplementedAs=continueFunction] IDBRequest getDatabaseNames();

... plus test updates.
Comment 1 Joshua Bell 2012-05-18 13:23:50 PDT 
Created attachment 142775 [details]
Patch
Comment 2 Joshua Bell 2012-05-18 13:41:31 PDT 
NOTE: Check (casually) to see if anyone is using this before landing.
Comment 3 Joshua Bell 2012-06-04 11:22:33 PDT 
Created attachment 145610 [details]
Patch
Comment 4 Joshua Bell 2012-06-04 11:23:51 PDT 
abarth@: r?
Comment 5 Joshua Bell 2012-06-06 10:24:19 PDT 
I probably don't need abarth@ to bless this one.

tony@ or ojan@?
Comment 6 WebKit Review Bot 2012-06-06 12:00:25 PDT 
Comment on attachment 145610 [details]
Patch

Clearing flags on attachment: 145610

Committed r119603: <http://trac.webkit.org/changeset/119603>
Comment 7 WebKit Review Bot 2012-06-06 12:00:32 PDT 
All reviewed patches have been landed.  Closing bug.