Bug 86867 – [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

EFL's LayoutTestController needs to implement sendWebIntentResponse which is needed by the following test cases:
  webintents/web-intents-failure.html
  webintents/web-intents-reply.html

[Chris Dumez]

Created attachment 143563 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 143563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143563&action=review

The EFL part looks OK, I'd prefer someone else to comment on the cross-port sendWebIntentResponseCallback.

> Tools/DumpRenderTree/LayoutTestController.cpp:2011
> +    if (argumentCount== 1) {

Nit: missing a space before '=='.

[Chris Dumez]

Created attachment 143567 [details]
Patch

Fix style nit. Thanks Rakuco.

[Adam Barth]

Comment on attachment 143567 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 143567 [details]
Patch

Rejecting attachment 143567 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
.h
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
patching file Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
patching file Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm
patching file Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp
patching file Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12780324

[Chris Dumez]

Created attachment 143731 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143731 [details]
Patch for landing

Clearing flags on attachment: 143731

Committed r118331: <http://trac.webkit.org/changeset/118331>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.