Bug 86866 - [EFL] EFL port does not enable WEB_INTENTS_TAG flag
Summary: [EFL] EFL port does not enable WEB_INTENTS_TAG flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 85364
Blocks: 86868
  Show dependency treegraph
 
Reported: 2012-05-18 10:06 PDT by Chris Dumez
Modified: 2012-06-01 09:36 PDT (History)
6 users (show)

See Also:


Attachments
Patch (16.07 KB, patch)
2012-06-01 04:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.11 KB, patch)
2012-06-01 08:06 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.38 KB, patch)
2012-06-01 08:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-18 10:06:23 PDT
EFL port does not enable WEB_INTENTS_TAG flag which is needed by the following test:
  webintents/intent-tag.html
Comment 1 Chris Dumez 2012-06-01 04:50:52 PDT
Created attachment 145271 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-06-01 07:06:09 PDT
Comment on attachment 145271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145271&action=review

> Source/WebCore/CMakeLists.txt:2527
> +        html/HTMLIntentElement.idl

We probably don't need this inside an IF(), as the code depends on ENABLE_WEB_INTENTS_TAG anyway.

> Source/WebCore/CMakeLists.txt:2535
> +       html/HTMLIntentElement.cpp

Ditto.
Comment 3 Chris Dumez 2012-06-01 08:06:16 PDT
Created attachment 145311 [details]
Patch

Take rakuco's feedback into consideration.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-06-01 08:35:31 PDT
Looks fine to me.
Comment 5 Chris Dumez 2012-06-01 08:52:43 PDT
Created attachment 145318 [details]
Patch

Rebase on master after conflicting patch landed.
Comment 6 Chris Dumez 2012-06-01 08:56:33 PDT
$ Tools/Scripts/run-webkit-tests --efl webintents
All 10 tests ran as expected.

Yay :)
Comment 7 Greg Billock 2012-06-01 09:08:04 PDT
awesome! :-)

(In reply to comment #6)
> $ Tools/Scripts/run-webkit-tests --efl webintents
> All 10 tests ran as expected.
> 
> Yay :)
Comment 8 WebKit Review Bot 2012-06-01 09:36:08 PDT
Comment on attachment 145318 [details]
Patch

Clearing flags on attachment: 145318

Committed r119243: <http://trac.webkit.org/changeset/119243>
Comment 9 WebKit Review Bot 2012-06-01 09:36:13 PDT
All reviewed patches have been landed.  Closing bug.