Bug 86865 – [EFL] EFL's LayoutTestController needs to implement deliverWebIntent

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

EFL's LayoutTestController needs to implement deliverWebIntent which is required by the following test case:
  webintents/web-intents-delivery.html

[Chris Dumez]

Created attachment 145258 [details]
Patch

[Chris Dumez]

Created attachment 145259 [details]
Patch

Add missing documentation.

[Gyuyoung Kim]

Comment on attachment 145259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145259&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:753
> +void ewk_frame_intent_deliver(Evas_Object *ewkFrame, Ewk_Intent *ewkIntent)

Move '*' operator to data type side.

By the way, it looks this is to get smartData object form ewkFrame object. Is it better to add const keyword ?

> Source/WebKit/efl/ewk/ewk_frame.h:711
> +EAPI void ewk_frame_intent_deliver(Evas_Object *o, Ewk_Intent *ewkIntent);

Change ewkIntent with ewk_intent.

[Chris Dumez]

Created attachment 145265 [details]
Patch

Thanks for catching this Gyuyoung.

[WebKit Review Bot]

Comment on attachment 145265 [details]
Patch

Clearing flags on attachment: 145265

Committed r119237: <http://trac.webkit.org/changeset/119237>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.