EFL's DRT needs to print information about received Web Intents. This is needed by the following test cases: webintents/web-intents-obj-constructor.html webintents/web-intents-failure.html webintents/web-intents-invoke-port.html webintents/web-intents-invoke.html webintents/web-intents-reload.html = TEXT webintents/web-intents-reply.html = TEXT The output looks like: Received Web Intent: action=action1 type=text/plain Received Web Intent: action=action1 type=text/plain+explicit Explicit intent service: http://explicit.com/ Received Web Intent: action=action1 type=text/plain+extras Extras[a] = b Received Web Intent: action=action1 type=text/plain+port Have 1 ports
Created attachment 143229 [details] Patch
Attachment 143229 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 LayoutTests/platform/efl/test_expectations.txt:119: fast/events/show-modal-dialog-onblur-onfocus.html is also in a Skipped file. [test/expectations] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Style issue is unrelated to this patch and will be addressed in Bug 87103.
Created attachment 143281 [details] Patch Reupload the patch to get a green style bubble.
Created attachment 143291 [details] Patch Fix a few style nits reported by Rakuco on IRC.
Comment on attachment 143291 [details] Patch Looks fine, thanks.
Comment on attachment 143291 [details] Patch All the manual memory management looks really fragile. I don't know enough about EFL to know whether it's correct.
abarth: There is unfortunately no reviewer with deep knowledge of EFL. Rakuco says the EFL part looks good to him and he is our reference. I don't see how I can avoid manual memory management here: I need to use the EFL types and C style.
Comment on attachment 143291 [details] Patch Ok. The intents-related parts look fine. If the EFL-related bits are fine, then we should be good to go.
Comment on attachment 143291 [details] Patch Clearing flags on attachment: 143291 Committed r118000: <http://trac.webkit.org/changeset/118000>
All reviewed patches have been landed. Closing bug.
The following tests are failing after this change: webintents/web-intents-api.html = TEXT webintents/web-intents-invoke.html = TEXT webintents/web-intents-reload.html = TEXT Br, Your gardener in duty.
Thiago: Based on the output on the bot, it appears it does not have the WEB_INTENTS flags enabled still. However, my patch enables it by default on EFL port and it works just fine on my machine. I think a clean build might be needed on the bot? Is it possible?
False alarm. Removing the CMake cache on the bot and building again fixed the issue. The web intents tests are now passing, as expected.
Awesome! :-) (In reply to comment #14) > False alarm. Removing the CMake cache on the bot and building again fixed the issue. The web intents tests are now passing, as expected.