Bug 86857 - [Qt] Add UI tests for fit-to-view
Summary: [Qt] Add UI tests for fit-to-view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on: 87236
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-18 08:38 PDT by Kenneth Rohde Christiansen
Modified: 2012-05-23 02:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.30 KB, patch)
2012-05-18 08:52 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-05-18 08:38:40 PDT
SSIA
Comment 1 Kenneth Rohde Christiansen 2012-05-18 08:52:22 PDT
Created attachment 142724 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-22 03:44:39 PDT
Comment on attachment 142724 [details]
Patch

Clearing flags on attachment: 142724

Committed r117942: <http://trac.webkit.org/changeset/117942>
Comment 3 WebKit Review Bot 2012-05-22 03:44:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-05-23 02:18:05 PDT
FYI - the newly added test fails with the following error message:

FAIL!  : qmltests::FitToView::test_basic() Compared values are not the same
   Actual   (): 0.5
   Expected (): 1
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml(96)]
Comment 5 Csaba Osztrogonác 2012-05-23 02:21:03 PDT
I filed a new bug report to fix this bug (because reopening bugs isn't allowed.) - https://bugs.webkit.org/show_bug.cgi?id=87236