This is required to implement the pseudo-state emulation on non-selected elements
Created attachment 143321 [details] Patch
Comment on attachment 143321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143321&action=review > Source/WebCore/ChangeLog:9 > + in the Web Inspector's context menu. ContextMenuItems are also passed/stored by reference/value rather than pointer I vaguely remember that when it was initially implemented, not all the platforms allowed treating ContextMenuItem as value type. Did this change?
(In reply to comment #2) > (From update of attachment 143321 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143321&action=review > > > Source/WebCore/ChangeLog:9 > > + in the Web Inspector's context menu. ContextMenuItems are also passed/stored by reference/value rather than pointer > > I vaguely remember that when it was initially implemented, not all the platforms allowed treating ContextMenuItem as value type. Did this change? Offline, we discovered that the platform objects represented by description are managed by the platform-specific code through the releasePlatformDescription() method.
Created attachment 143538 [details] Patch
Comment on attachment 143538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143538&action=review Make sure you implement SoftContextMenu based on the new descriptor. > Source/WebCore/inspector/front-end/ContextMenu.js:45 > + this._topLevelMenu = topLevelMenu; this._contextMenu > Source/WebCore/inspector/front-end/ContextMenu.js:51 > + get id() id: function() > Source/WebCore/inspector/front-end/ContextMenu.js:56 > + get type() type: function() > Source/WebCore/inspector/front-end/ContextMenu.js:95 > + this._topLevelMenu.setHandler(item.id, handler); Make it all private. > Source/WebCore/inspector/front-end/ContextMenu.js:143 > + toProtocol: function() _buildDescriptor:
Created attachment 143788 [details] Patch
Comment on attachment 143788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143788&action=review > Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:80 > + v8::Local<v8::Value> subItems = item->Get(v8::String::New("subItems")); subItems -> items ?
Committed r118374: <http://trac.webkit.org/changeset/118374>