Bug 86838 - [EFL][DRT] Key modifier bit flags have enum type.
Summary: [EFL][DRT] Key modifier bit flags have enum type.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 85369
  Show dependency tree / graph
 
Reported: 2012-05-18 03:22 PDT by Mikhail Pozdnyakov
Modified: 2012-05-22 11:11 PDT (History)
4 users (show)

See Also:

Attachments
patch (2.65 KB, patch)
2012-05-18 04:47 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (review comments are met) (7.47 KB, patch)
2012-05-21 07:01 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-05-18 03:22:39 PDT 
Key modifier bit flags have enum type. It causes problems as a key can have several modifiers at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift) will be out of EvasKeyModifier enum, so refactoring is needed here.
Comment 1 Mikhail Pozdnyakov 2012-05-18 04:47:45 PDT 
Created attachment 142686 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-18 08:00:19 PDT 
Comment on attachment 142686 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142686&action=review

I'd rather change the type of KeyEventInfo::modifiers to unsigned (as is already done in places such as PlatformEvent.h in WebCore) and keep the enum an enum.

> Tools/ChangeLog:8
> +        Refactoring. EvasKeyModifier is unsigned int.

Your explanation in the original bug comment is much more helpful, please consider adding it here.
Comment 3 Mikhail Pozdnyakov 2012-05-21 07:01:49 PDT 
Created attachment 143025 [details]
patch v2 (review comments are met)
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-21 08:21:29 PDT 
Comment on attachment 143025 [details]
patch v2 (review comments are met)

Looks good to me.
Comment 5 WebKit Review Bot 2012-05-22 11:11:13 PDT 
Comment on attachment 143025 [details]
patch v2 (review comments are met)

Clearing flags on attachment: 143025

Committed r118006: <http://trac.webkit.org/changeset/118006>
Comment 6 WebKit Review Bot 2012-05-22 11:11:18 PDT 
All reviewed patches have been landed.  Closing bug.