Bug 86831 - [V8] Remove V8Proxy::notHandledByInterceptor()
Summary: [V8] Remove V8Proxy::notHandledByInterceptor()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 85330
  Show dependency treegraph
Reported: 2012-05-18 02:20 PDT by Kentaro Hara
Modified: 2012-08-03 09:54 PDT (History)
4 users (show)

See Also:

Patch (35.79 KB, patch)
2012-05-18 02:26 PDT, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (35.77 KB, patch)
2012-05-20 17:24 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-18 02:20:59 PDT
As per the discussion in https://bugs.webkit.org/show_bug.cgi?id=85330, we replace 'return V8Proxy::notHandledByInterceptor()' with 'return v8::Handle<v8::Value>()'.
Comment 1 Kentaro Hara 2012-05-18 02:26:18 PDT
Created attachment 142672 [details]
Comment 2 Adam Barth 2012-05-18 04:43:08 PDT
Comment on attachment 142672 [details]

Death to the cargo cult.
Comment 3 WebKit Review Bot 2012-05-18 05:33:44 PDT
Comment on attachment 142672 [details]

Rejecting attachment 142672 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11551 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11551.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12721795
Comment 4 Adam Barth 2012-05-18 05:47:57 PDT
Sorry for the bad error messages:

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

I think this hit a merge conflict at the very end of the commit cycle.
Comment 5 Kentaro Hara 2012-05-20 17:24:39 PDT
Created attachment 142929 [details]
patch for landing
Comment 6 WebKit Review Bot 2012-05-21 19:30:29 PDT
Comment on attachment 142929 [details]
patch for landing

Clearing flags on attachment: 142929

Committed r117873: <http://trac.webkit.org/changeset/117873>
Comment 7 Adam Barth 2012-08-03 09:54:10 PDT
Looks like this landed a while ago.