Bug 8683 - REGRESSION: imdb search button has "Submit" overlaid after going back
Summary: REGRESSION: imdb search button has "Submit" overlaid after going back
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL: http://imdb.com/title/tt0120907/
Keywords: EasyFix, HasReduction, Regression
Depends on:
Blocks:
 
Reported: 2006-05-01 09:18 PDT by Daniele Metilli
Modified: 2006-05-05 08:18 PDT (History)
1 user (show)

See Also:


Attachments
patch that addresses this bug and also a poor data structure for form restore (104.31 KB, patch)
2006-05-04 08:34 PDT, Darin Adler
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele Metilli 2006-05-01 09:18:42 PDT
This bug has previously been reported in the comments of bug 7691.

How to reproduce this:

1 - Go to http://imdb.com/title/tt0120907/
2 - Click on "David Cronenberg".
3 - Go back using Safari's back button.
4 - The search button is rendered incorrectly.

This happens in TOT (r14126).

Darin said about this:

The new bug doesn't have to do with the button rendering itself, but rather
with the way form data is saved and restored. Apparently a null is saved, but
an empty string is restored, or vice versa.

The fix will be to change HTMLInputElement::state and
HTMLInputElement::restoreState so they can distinguish a state of null string
from a state of empty string, which should be straightforward.
Comment 1 Darin Adler 2006-05-04 08:34:57 PDT
Created attachment 8103 [details]
patch that addresses this bug and also a poor data structure for form restore
Comment 2 Adele Peterson 2006-05-04 21:17:49 PDT
Comment on attachment 8103 [details]
patch that addresses this bug and also a poor data structure for form restore

I think it would be worth checking in a manual test for this.