Bug 86808 - [perf-test] Add a binding benchmark for getElementById()
Summary: [perf-test] Add a binding benchmark for getElementById()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 86581
  Show dependency treegraph
 
Reported: 2012-05-17 22:35 PDT by Kentaro Hara
Modified: 2012-05-17 23:29 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.28 KB, patch)
2012-05-17 22:41 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-17 22:35:58 PDT
Currently Bindings/dom-attributes.html is just a collection of random DOM attributes and methods. We should remove it and instead add more reasonable micro benchmarks by classifying DOM binding call paths.

In this bug we add a benchmark for document.getElementById(), which covers other DOM methods that return a Node Object.

The reason why we want to add a benchmark for document.getElementById() in spite of the fact that Dromaeo/dom-query.html is already testing document.getElementById(), is that Dromaeo/dom-query.html outputs one result for several benchmarks (i.e. getElementById().nodeType, getElementsByTagName()[0].nodeType etc), and thus we cannot observe regression of getElementById() itself. (Catching regression of getElementById() would be critical.)
Comment 1 Kentaro Hara 2012-05-17 22:41:02 PDT
Created attachment 142633 [details]
Patch
Comment 2 Ryosuke Niwa 2012-05-17 22:48:51 PDT
Comment on attachment 142633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142633&action=review

> PerformanceTests/ChangeLog:22
> +        getElementById() would be critical.)

I wouldn't say "critical" but sure.
Comment 3 WebKit Review Bot 2012-05-17 23:29:16 PDT
Comment on attachment 142633 [details]
Patch

Clearing flags on attachment: 142633

Committed r117548: <http://trac.webkit.org/changeset/117548>
Comment 4 WebKit Review Bot 2012-05-17 23:29:20 PDT
All reviewed patches have been landed.  Closing bug.