RESOLVED FIXED Bug 86798
A couple of UI nits about the flagging feature in results.html 
https://bugs.webkit.org/show_bug.cgi?id=86798
Summary A couple of UI nits about the flagging feature in results.html
Ojan Vafai
Reported 2012-05-17 19:36:35 PDT
Ryosuke and I were talking and I realized that he didn't know about the flagging feature in results.html because it's hidden behind a key command. A couple UI ideas to make it more discoverable and user-friendly: 1. Add a "hollow" flag icon where the flags current go for unflagged files. This both makes it discoverable and gives a way to flag files with the mouse (i.e. click on the hollow flag, it becomes a solid flag and is flagged.). 2. Make the flagged contentEditable section position:fixed at the bottom of the window. Right now, if there are too many failures, it's annoying to have to scroll to the bottom of the page to get the list of flagged files.
Attachments
Patch (11.89 KB, patch)
2012-07-17 12:38 PDT, Ojan Vafai 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-06-21 07:57:37 PDT
Another idea: -Add a hollow flag at the beginning of each test list (or at least, at the beginning of the unexpected failures list) so I can flag all the tests in that list with a single clic
Ojan Vafai
Comment 2 2012-07-17 12:38:05 PDT
Created attachment 152807 [details] Patch
Ojan Vafai
Comment 3 2012-07-17 15:22:19 PDT
Committed r122880: <http://trac.webkit.org/changeset/122880>
Simon Fraser (smfr)
Comment 4 2012-07-30 16:49:53 PDT
This broke keyboard navigation of the result: bug 92584
Note You need to log in before you can comment on or make changes to this bug.