RESOLVED WONTFIX86789
We should try to download the built product before other steps 
https://bugs.webkit.org/show_bug.cgi?id=86789
Summary We should try to download the built product before other steps
Lucas Forschler
Reported 2012-05-17 17:30:34 PDT
Currently our test bots do an svn operation to sync up source, and then downloads the built product to test. Normally this is fine. However when bots get behind, the build product has been removed due to space constraints. In this scenario, when the self.addStep(DownloadBuiltProduct) runs, the file does not exist, and the rest of the of the steps are aborted. We should put the DownloadBuildProduct step BEFORE the svn operation, such that we can short circuit the svn operation which takes a fair amount of time.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-05-17 17:34:40 PDT
(In reply to comment #0) > Currently our test bots do an svn operation to sync up source, and then downloads the built product to test. Normally this is fine. However when bots get behind, the build product has been removed due to space constraints. In this scenario, when the self.addStep(DownloadBuiltProduct) runs, the file does not exist, and the rest of the of the steps are aborted. > > We should put the DownloadBuildProduct step BEFORE the svn operation, such that we can short circuit the svn operation which takes a fair amount of time. Hm... there is a slight problem with this, which is that sometimes "svn up" and failing would remove the entire checkout. That may prune the build files as well. Or maybe that's rare enough event that we can just ignore it?
Stephanie Lewis
Comment 2 2012-05-17 17:41:28 PDT
If he writes this correctly it should never even start the svn step. I don't think it would remove itself in that case.
Lucas Forschler
Comment 3 2012-05-17 17:43:47 PDT
I think we'd need an extra factory. At first, I thought we could simply move the addStep(DownloadBuiltProduct) from TestFactory to Factory. However, then it would run every time the base Factory class was called. (Not just TestFactory). Also, I do know we are getting more storage in the next month or so, which should alleviate this problem. However, we should be smart in software and not rely on the storage (or lack of) to 'do the right thing.'
Stephanie Lewis
Comment 4 2012-05-17 17:45:48 PDT
Nevermind, I see what you're getting at. Maybe we should download to someplace that is not in the svn checkout?
Lucas Forschler
Comment 5 2017-03-30 14:05:35 PDT
I'm not sure this is relevant any longer... svn operations are fairly quick, except for new checkouts... I think we should just close it.
Note You need to log in before you can comment on or make changes to this bug.