Bug 86778 – Linux amd64 platform reported as i686

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Michael Moss]

Linux amd64 platform reported as i686

[Michael Moss]

Created attachment 142566 [details]
Patch

[WebKit Review Bot]

Attachment 142566 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Moss]

Created attachment 142570 [details]
Patch

[Tony Chang]

Comment on attachment 142570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142570&action=review

LGTM.  I'll wait for the ews bots to go green before setting cq+.

> Source/WebCore/ChangeLog:7
> +        http://code.google.com/p/chromium/issues/detail?id=128167
> +
> +        Reviewed by NOBODY (OOPS!).

Nit: You could add some text here about this code pre-dating the code in WebCore to detect this at runtime.

[Michael Moss]

Created attachment 142578 [details]
Patch

[Michael Moss]

Created attachment 142590 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 142590 [details]
Patch for landing

Rejecting attachment 142590 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 142590 [details]
Patch for landing

Clearing flags on attachment: 142590

Committed r117524: <http://trac.webkit.org/changeset/117524>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.