RESOLVED FIXED 86777
[Chromium] Move fileUtilities to Platform.h 
https://bugs.webkit.org/show_bug.cgi?id=86777
Summary [Chromium] Move fileUtilities to Platform.h
Mark Pilgrim (Google)
Reported 2012-05-17 14:56:14 PDT
[Chromium] Move fileUtilities to Platform.h
Attachments
Patch (17.39 KB, patch)
2012-05-17 14:56 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-17 14:56:58 PDT
Created attachment 142561 [details] Patch
WebKit Review Bot
Comment 2 2012-05-17 14:59:10 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-05-17 15:15:36 PDT
Comment on attachment 142561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142561&action=review > Source/WebKit/chromium/src/PlatformSupport.cpp:302 > bool PlatformSupport::fileExists(const String& path) After this patch, can we remove these functions?
WebKit Review Bot
Comment 4 2012-05-17 16:33:39 PDT
Comment on attachment 142561 [details] Patch Rejecting attachment 142561 [details] from commit-queue. pilgrim@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Mark Pilgrim (Google)
Comment 5 2012-05-17 16:34:35 PDT
Damn it, I hit the wrong dropdown item. (Well, also I do have committer rights, but never mind that.)
Mark Pilgrim (Google)
Comment 6 2012-05-17 16:35:33 PDT
(In reply to comment #3) > (From update of attachment 142561 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142561&action=review > > > Source/WebKit/chromium/src/PlatformSupport.cpp:302 > > bool PlatformSupport::fileExists(const String& path) > > After this patch, can we remove these functions? Sure, I'll give it a shot.
Adam Barth
Comment 7 2012-05-17 17:59:20 PDT
Comment on attachment 142561 [details] Patch You should write a patch that adds yourself to committers.py.
WebKit Review Bot
Comment 8 2012-05-17 18:11:52 PDT
Comment on attachment 142561 [details] Patch Clearing flags on attachment: 142561 Committed r117520: <http://trac.webkit.org/changeset/117520>
WebKit Review Bot
Comment 9 2012-05-17 18:11:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.