Bug 86777 - [Chromium] Move fileUtilities to Platform.h
Summary: [Chromium] Move fileUtilities to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-05-17 14:56 PDT by Mark Pilgrim (Google)
Modified: 2012-05-17 18:11 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.39 KB, patch)
2012-05-17 14:56 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-17 14:56:14 PDT 
[Chromium] Move fileUtilities to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-17 14:56:58 PDT 
Created attachment 142561 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-17 14:59:10 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-05-17 15:15:36 PDT 
Comment on attachment 142561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142561&action=review

> Source/WebKit/chromium/src/PlatformSupport.cpp:302
>  bool PlatformSupport::fileExists(const String& path)

After this patch, can we remove these functions?
Comment 4 WebKit Review Bot 2012-05-17 16:33:39 PDT 
Comment on attachment 142561 [details]
Patch

Rejecting attachment 142561 [details] from commit-queue.

pilgrim@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 Mark Pilgrim (Google) 2012-05-17 16:34:35 PDT 
Damn it, I hit the wrong dropdown item. (Well, also I do have committer rights, but never mind that.)
Comment 6 Mark Pilgrim (Google) 2012-05-17 16:35:33 PDT 
(In reply to comment #3)
> (From update of attachment 142561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142561&action=review
> 
> > Source/WebKit/chromium/src/PlatformSupport.cpp:302
> >  bool PlatformSupport::fileExists(const String& path)
> 
> After this patch, can we remove these functions?

Sure, I'll give it a shot.
Comment 7 Adam Barth 2012-05-17 17:59:20 PDT 
Comment on attachment 142561 [details]
Patch

You should write a patch that adds yourself to committers.py.
Comment 8 WebKit Review Bot 2012-05-17 18:11:52 PDT 
Comment on attachment 142561 [details]
Patch

Clearing flags on attachment: 142561

Committed r117520: <http://trac.webkit.org/changeset/117520>
Comment 9 WebKit Review Bot 2012-05-17 18:11:58 PDT 
All reviewed patches have been landed.  Closing bug.