Bug 86775 - Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
Summary: Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 85555
  Show dependency tree / graph
 
Reported: 2012-05-17 14:19 PDT by Levi Weintraub
Modified: 2012-05-24 10:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2012-05-17 14:26 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-05-17 14:19:36 PDT 
Currently we take floats but always paint at whole y coordinates. This patch will preserve that behavior with the sub-pixel conversion. Otherwise, some underlines and strike-throughs end up midway between two pixels.
Comment 1 Levi Weintraub 2012-05-17 14:26:35 PDT 
Created attachment 142556 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-17 14:28:18 PDT 
Comment on attachment 142556 [details]
Patch

Does Skia floor the X for us?  I'm confused?
Comment 3 Levi Weintraub 2012-05-17 18:54:14 PDT 
(In reply to comment #2)
> (From update of attachment 142556 [details])
> Does Skia floor the X for us?  I'm confused?

I'm going to add a comment. We always draw these lines horizontally. Sub-pixel x values are normal and acceptable.
Comment 4 Levi Weintraub 2012-05-24 10:23:55 PDT 
Forgot to comment... landed in r117528 <http://trac.webkit.org/changeset/117528>