Bug 86773 – Don't let -[CALayer renderInContext:] try to render WebView's root layer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

Don't let -[CALayer renderInContext:] try to render WebView's root layer

[Andy Estes]

Created attachment 142548 [details]
Patch

[Andy Estes]

<rdar://problem/10950075>

Comment on attachment 142548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:215
> +@interface WebLayerHostingLayer : CALayer

I don’t think there’s such a thing as a “layer hosting layer”. Would it be wrong to call this class WebRootLayer?

[Simon Fraser (smfr)]

Comment on attachment 142548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review

> Source/WebKit/mac/ChangeLog:4
> +        Don't let -[CALayer renderInContext:] try to render WebView's root layer
> +        https://bugs.webkit.org/show_bug.cgi?id=86773

You should list the radar here too.

> Source/WebKit/mac/WebView/WebHTMLView.mm:5483
> -    CALayer* viewLayer = [CALayer layer];
> +    CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease];

Pretty sure you can still call [WebLayerHostingLayer layer].

[Andy Estes]

(In reply to comment #3)
> (From update of attachment 142548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review
> 
> > Source/WebKit/mac/WebView/WebHTMLView.mm:215
> > +@interface WebLayerHostingLayer : CALayer
> 
> I don’t think there’s such a thing as a “layer hosting layer”. Would it be wrong to call this class WebRootLayer?

Nope, it would be very right! Will rename.

[Andy Estes]

(In reply to comment #4)
> (From update of attachment 142548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review
> 
> > Source/WebKit/mac/ChangeLog:4
> > +        Don't let -[CALayer renderInContext:] try to render WebView's root layer
> > +        https://bugs.webkit.org/show_bug.cgi?id=86773
> 
> You should list the radar here too.

Ok.

> 
> > Source/WebKit/mac/WebView/WebHTMLView.mm:5483
> > -    CALayer* viewLayer = [CALayer layer];
> > +    CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease];
> 
> Pretty sure you can still call [WebLayerHostingLayer layer].

Yeah, I can and will.

[Andy Estes]

(In reply to comment #4)
> (From update of attachment 142548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review
> > Source/WebKit/mac/WebView/WebHTMLView.mm:5483
> > -    CALayer* viewLayer = [CALayer layer];
> > +    CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease];
> 
> Pretty sure you can still call [WebLayerHostingLayer layer].

Oh, no I can't since it's a class method.

[Andy Estes]

(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 142548 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review
> > > Source/WebKit/mac/WebView/WebHTMLView.mm:5483
> > > -    CALayer* viewLayer = [CALayer layer];
> > > +    CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease];
> > 
> > Pretty sure you can still call [WebLayerHostingLayer layer].
> 
> Oh, no I can't since it's a class method.

Please ignore me. This works fine.

[Andy Estes]

Committed r117510: <http://trac.webkit.org/changeset/117510>