Bug 86755 - [Chromium] Move cookieJar to Platform.h
Summary: [Chromium] Move cookieJar to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-05-17 11:09 PDT by Mark Pilgrim (Google)
Modified: 2012-05-22 16:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.52 KB, patch)
2012-05-17 11:10 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (8.63 KB, patch)
2012-05-22 14:50 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (14.57 KB, patch)
2012-05-22 14:52 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-17 11:09:39 PDT 
[Chromium] Move cookieJar to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-17 11:10:29 PDT 
Created attachment 142507 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-17 11:13:54 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-05-21 15:45:36 PDT 
Comment on attachment 142507 [details]
Patch

Rejecting attachment 142507 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
nk #2 succeeded at 69 (offset -5 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h.rej
patching file Source/WebKit/chromium/src/PlatformSupport.cpp
Hunk #1 succeeded at 50 with fuzz 2.
Hunk #2 succeeded at 93 with fuzz 2.
Hunk #3 succeeded at 135 (offset 1 line).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12739596
Comment 4 Mark Pilgrim (Google) 2012-05-22 14:50:39 PDT 
Created attachment 143369 [details]
Patch
Comment 5 Mark Pilgrim (Google) 2012-05-22 14:52:59 PDT 
Created attachment 143370 [details]
Patch
Comment 6 WebKit Review Bot 2012-05-22 16:40:37 PDT 
Comment on attachment 143370 [details]
Patch

Clearing flags on attachment: 143370

Committed r118080: <http://trac.webkit.org/changeset/118080>
Comment 7 WebKit Review Bot 2012-05-22 16:40:47 PDT 
All reviewed patches have been landed.  Closing bug.